Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the trim requirements on MetadataUpdateHandlerAttribute #84369

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

pedrobsaila
Copy link
Contributor

Fixes #66069

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Apr 5, 2023
@ghost
Copy link

ghost commented Apr 5, 2023

Tagging subscribers to this area: @dotnet/area-system-reflection
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66069

Author: pedrobsaila
Assignees: -
Labels:

area-System.Reflection, new-api-needs-documentation

Milestone: -

@pedrobsaila
Copy link
Contributor Author

@vitek-karas I tried updating MetadataUpdateHandlerAttribute but got compatibility errors with .net7.0.
Is introducing a breaking change intended ? if yes how to by pass the check ?

@vitek-karas
Copy link
Member

This is hitting the same problem as #84326 - just different attribute.
In this case it's a bit more subtle: For DynamicallyAccessedMembersAttribute it should be OK to reduce the annotation (in this case from All to "all methods only"). It should NOT be OK to broaden the annotation as that may introduce new warnings.

Do we have a way to baseline just one specific attribute difference - as intentional?

@ericstj @eerhardt

@vitek-karas vitek-karas added the linkable-framework Issues associated with delivering a linker friendly framework label Apr 6, 2023
@ghost
Copy link

ghost commented Apr 6, 2023

Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #66069

Author: pedrobsaila
Assignees: -
Labels:

area-System.Reflection, new-api-needs-documentation, linkable-framework, community-contribution

Milestone: -

@eerhardt
Copy link
Member

eerhardt commented Apr 6, 2023

In 7.0 we had

https://github.com/dotnet/runtime/blob/release/7.0/src/libraries/apicompat/ApiCompatBaseline.NetCoreAppLatestStable.txt

that allowed us to baseline specific known API compat issues. But I'm not seeing this in main. @ericstj, @ViktorHofer ?

@ericstj
Copy link
Member

ericstj commented Apr 6, 2023

It's the new format in Main: https://github.com/dotnet/runtime/blob/main/src/libraries/apicompat/ApiCompatBaseline.NetCoreAppLatestStable.xml

You could modify it directly, or try generating it.

To generate it you could do:

dotnet build ApiCompat.proj /p:ApiCompatGenerateSuppressionFile=true

@steveharter steveharter self-requested a review April 19, 2023 18:18
@steveharter
Copy link
Member

@pedrobsaila thanks for this contribution.

@steveharter steveharter added this to the 8.0.0 milestone Apr 19, 2023
@steveharter steveharter merged commit 9a1f9c5 into dotnet:main Apr 19, 2023
@pedrobsaila pedrobsaila deleted the 66069 branch April 19, 2023 18:21
@ghost ghost locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Reflection community-contribution Indicates that the PR has been added by a community member linkable-framework Issues associated with delivering a linker friendly framework new-api-needs-documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce the trim requirements on MetadataUpdateHandlerAttribute
5 participants